labath accepted this revision. labath added a comment. This revision is now accepted and ready to land.
Looks good. Please also run clang-format over the patch (also when I don't request it, i tend to forget about that). ================ Comment at: source/Plugins/Platform/Android/AdbClient.cpp:429 @@ +428,3 @@ + dst.write (&output_buffer[0], output_buffer.size ()); + return Error (); +} ---------------- We should close the file and make check for the error flags on the stream to make sure the write was successful. http://reviews.llvm.org/D22081 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
