amccarth added a comment.
I like where this is going. Just a couple concerns.
================
Comment at: tools/driver/Platform.h:15
@@ -14,4 +14,3 @@
// this will stop signal.h being included
#include "lldb/Host/HostGetOpt.h"
----------------
delete this comment
================
Comment at: tools/driver/Platform.h:40
@@ -39,14 +39,3 @@
-
- // signal handler function pointer type
- typedef void(*sighandler_t)(int);
-
- // signal.h
- #define SIGINT 2
- // default handler
- #define SIG_DFL ( (sighandler_t) -1 )
- // ignored
- #define SIG_IGN ( (sighandler_t) -2 )
-
// signal.h
#define SIGPIPE 13
----------------
Now that we are including <signal.h>, won't the following defines create
duplicate definition warnings for the non-Windows platforms?
================
Comment at: tools/lldb-mi/Platform.h:73
@@ -74,4 +72,3 @@
// CODETAG_IOR_SIGNALS
// signal.h
#define SIGQUIT 3 // Terminal quit signal
----------------
As in the other file, now that we're including <signal.h>, I think the
following definitions may be unnecessary and might cause compile-time warnings
for non-Windows systems.
http://reviews.llvm.org/D18287
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
