zturner added inline comments. ================ Comment at: tools/lldb-mi/Platform.h:73 @@ -74,4 +72,3 @@ // CODETAG_IOR_SIGNALS // signal.h #define SIGQUIT 3 // Terminal quit signal ---------------- amccarth wrote: > As in the other file, now that we're including <signal.h>, I think the > following definitions may be unnecessary and might cause compile-time > warnings for non-Windows systems. No, because Windows doesn't define them in the first place. Windows only defines the 5 or 6 values it supports. These are here so as to avoid having to fix up the remaining 10-20 locations and wrap them in pre-processor definitions. `signal()` will just return an error if called with these values, but it's no different than the old implementation where we simply ignored the values by way of a switch statement that did nothing.
http://reviews.llvm.org/D18287 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
