ldrumm added inline comments.
================
Comment at:
source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp:559-560
@@ -558,5 +558,4 @@
-static bool FindFunctionInModule (ConstString &mangled_name,
- llvm::Module *module,
- const char *orig_name)
+static bool
+FindFunctionInModule(ConstString &mangled_name, llvm::Module *module, const
char *orig_name)
{
----------------
jingham wrote:
> Don't make this kind of change, please. As long as the arguments fit in 120
> characters we don't have a rule one way or the other about how to write
> argument lists like this. But changing them just because they look better to
> you results in unnecessary churn. Moreover, this is changing it away from
> the way all the other functions in this source file are written, so it ends
> up looking odd.
This change is made by clang-fomat using the rules in the lldb .clang-format
file.
I'm willing to revert this part of the commit, but seeing as this change is
essentially a refactoring of the whole method, it feels natural to also format
the prototype while I’m at it.
http://reviews.llvm.org/D17274
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
