> On Jan 27, 2016, at 9:20 AM, Jim Ingham via lldb-commits > <lldb-commits@lists.llvm.org> wrote: > > >> On Jan 27, 2016, at 8:25 AM, Enrico Granata via lldb-commits >> <lldb-commits@lists.llvm.org> wrote: >> >> granata.enrico added a comment. >> >> It looks like this code is default constructing a SBExpressionOptions(), >> which at the end of the day is a fancy wrapper for EvaluateExpressionOptions >> >> This last object gets default constructed with >> >> m_ignore_breakpoints (false), >> >> I wonder whether that is a useful default value to begin with. My personal >> preference would be to change that default to be true and then everyone >> would by default get it "right" for what looks to me like the most common >> use case. > > For SBFrame::EvaluateExpressions I agree that ignoring breakpoints is a > better default - especially since that's the default for the command line as > well. Probably just an oversight on my part. So we should just flip the > default constructor (and make sure the testsuite agrees this was the right > thing to do...)
Not what I meant to say. For ALL expression evaluations, ignoring the breakpoints is the better default... Jim > > Jim > >> >> With that said, if there is a reason for that default to be what it is (and >> I don't know right now and am not in the office to ask), then your patch >> would seem reasonable to me as long as you make the same change in all >> overloads of EvaluateExpression() except the one that explicitly takes an >> SBExpressionOptions. >> >> >> http://reviews.llvm.org/D15778 >> >> >> >> _______________________________________________ >> lldb-commits mailing list >> lldb-commits@lists.llvm.org >> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits > > _______________________________________________ > lldb-commits mailing list > lldb-commits@lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
