amccarth created this revision.
amccarth added a reviewer: zturner.
amccarth added a subscriber: lldb-commits.
Apparently something changed with `thread step-over`, causing execution to move
outside the stack frame, and thus the local variables were no longer visible.
Since the step-over is unrelated to the purpose of the test and since the
comment for that line was just plain wrong (the breakpoint set is already
beyond the last assignment, so this seems legit), I deleted that step.
Tested on Windows with both Python 2.7 and 3.5.
http://reviews.llvm.org/D16334
Files:
packages/Python/lldbsuite/test/lang/cpp/signed_types/TestSignedTypes.py
Index: packages/Python/lldbsuite/test/lang/cpp/signed_types/TestSignedTypes.py
===================================================================
--- packages/Python/lldbsuite/test/lang/cpp/signed_types/TestSignedTypes.py
+++ packages/Python/lldbsuite/test/lang/cpp/signed_types/TestSignedTypes.py
@@ -48,9 +48,6 @@
self.expect("breakpoint list -f", BREAKPOINT_HIT_ONCE,
substrs = [' resolved, hit count = 1'])
- # Execute the assignment statement.
- self.runCmd("thread step-over")
-
# Test that signed types display correctly.
self.expect("frame variable --show-types --no-args",
VARIABLES_DISPLAYED_CORRECTLY,
patterns = ["\((short int|short)\) the_signed_short = 99",
Index: packages/Python/lldbsuite/test/lang/cpp/signed_types/TestSignedTypes.py
===================================================================
--- packages/Python/lldbsuite/test/lang/cpp/signed_types/TestSignedTypes.py
+++ packages/Python/lldbsuite/test/lang/cpp/signed_types/TestSignedTypes.py
@@ -48,9 +48,6 @@
self.expect("breakpoint list -f", BREAKPOINT_HIT_ONCE,
substrs = [' resolved, hit count = 1'])
- # Execute the assignment statement.
- self.runCmd("thread step-over")
-
# Test that signed types display correctly.
self.expect("frame variable --show-types --no-args", VARIABLES_DISPLAYED_CORRECTLY,
patterns = ["\((short int|short)\) the_signed_short = 99",
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
