tberghammer added a comment.

In general I like the approach you are taking and creating 
IsAlwaysThumbInstructions sounds like a good idea, but I would implement it a 
bit differently.

llvm::Triple already contains a SubArch field what is filled in from the first 
part of the triple in case of arm so I would prefer to use that instead because 
then we update the architecture information inside the Triple also what is used 
in many places (I would expect that the information you put into the core field 
will get lost at some place).

Just for curiosity, how do you debug a Cortex-M4 processor? Do you have 
PlatformJTAG/ProcessJTAG implementations or do you use debugserver on them?


Repository:
  rL LLVM

http://reviews.llvm.org/D13578



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to