On 08/27/2015 07:37 PM, Michael Ellerman wrote:
On Thu, 2015-27-08 at 06:01:16 UTC, Alexey Kardashevskiy wrote:
"powerpc/iommu: Cleanup setting of DMA base/offset" expects that
This should be:
Commit e91c25111aa3 "powerpc/iommu: Cleanup setting of DMA base/offset" ...
Is not this format for reverts (which this patch is not)?
the default DMA offset is set from pnv_ioda_setup_bus_dma() which
is correct unless it is SRIOV where the code flow is different - at
the moment when pnv_ioda_setup_bus_dma() is called, there is no PE for
the just created VF.
This adds missing set_dma_offset() to pnv_pci_ioda_dma_dev_setup()
to cover the case of SRIOV.
Note that we still need set_dma_offset() in pnv_ioda_setup_bus_dma()
as at the boot time pnv_pci_ioda_dma_dev_setup() is called when no PE
was created yet, this happens at the PHB fixup stage.
And here we should have:
Fixes: e91c25111aa3 ("powerpc/iommu: Cleanup setting of DMA base/offset")
Signed-off-by: Alexey Kardashevskiy <a...@ozlabs.ru>
Reviewed-by: Gavin Shan <gws...@linux.vnet.ibm.com>
---
Makes sense to squash it to "powerpc/iommu: Cleanup setting of DMA base/offset".
We don't squash things that are already in next.
imho this screams for rebase. There is no point in having broken patches in
non merged tree, rebase is a very cheap operation.
I've fixed the change log up with my comments above and your reworded
explanation.
Thanks!
cheers
--
Alexey
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
