On Tue, Jun 02, 2015 at 10:12:03AM -0700, Sukadev Bhattiprolu wrote: > At run time, (i.e when perf is starting up), locate the specific events > table for the current CPU and create event aliases for each of the events. > > Use these aliases to parse user's specified perf event. > > Signed-off-by: Sukadev Bhattiprolu <suka...@linux.vnet.ibm.com> > > Changelog[v3] > [Jiri Olsa] Fix a memory leak with cpuid. > > Changelog[v2] > [Andi Kleen] Replace the pmu_events_map->vfm field with a simple > generic "cpuid" string and use that string to find the > matching mapfile entry. > --- > tools/perf/arch/powerpc/util/header.c | 11 ++++ > tools/perf/util/header.h | 3 +- > tools/perf/util/pmu.c | 104 > ++++++++++++++++++++++++++++----- > 3 files changed, 104 insertions(+), 14 deletions(-)
I think this patch is doing too much, it should be split into 3 pieces: - introduce get_cpuid_str for powerpc - introducing __perf_pmu__new_alias/perf_pmu__new_alias functions split - adding pmu_add_cpu_aliases functionality jirka _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
