On Mon, 2014-12-08 at 09:21 -0600, Nathan Fontenot wrote: > > Oh I was hoping you would not say that :( > > Heh! hint taken. I won't cc you. > > > > > Seriously? Parsing binary blobs from userspace? Don't do that, you > > know better. > > Yes, not ideal. One thing to note here is that the code to parse these > binary blobs already exists in the kernel for powerpc. The binary blob > we need to pass in is the same format as rtas error logs that we can be > handed by firmware on powerpc systems.
We should clarify that it's a small blob, it's an error log entry as defined by our firmware interfaces. We already obtain these from the FW and parse them (it's really just mapping the right structure based on the type in the header) under various circumstances. What happens is on KVM, we used that existing path to signal the kernel of an hotplug event. On PowerVM (aka pHyp), we want to use the same kernel code path by passing an equivalent event to the kernel. Nathan, if Greg still strongly objects, we could have the sysfs interface be something like a simple action + resource ID string, we don't *need* it to be encapsulated in an error log, we would just pipe into the same infrastructure in the kernel but at a slightly lower level... Ben. _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
