On Thu, 2014-08-21 at 22:19 -0400, Pranith Kumar wrote: > Fix the following build error: > > drivers/edac/ppc4xx_edac.c: In function 'mfsdram': > drivers/edac/ppc4xx_edac.c:249: error: implicit declaration of function > '__mfdcri' > drivers/edac/ppc4xx_edac.c: In function 'mtsdram': > drivers/edac/ppc4xx_edac.c:266: error: implicit declaration of function > '__mtdcri' > drivers/edac/ppc4xx_edac.c:269: warning: 'return' with a value, in function > returning void > drivers/edac/ppc4xx_edac.c: In function 'ppc4xx_edac_init_csrows': > drivers/edac/ppc4xx_edac.c:924: warning: initialization from incompatible > pointer type > drivers/edac/ppc4xx_edac.c:977: error: request for member 'dimm' in something > not a structure or union > drivers/edac/ppc4xx_edac.c: In function 'ppc4xx_edac_map_dcrs': > drivers/edac/ppc4xx_edac.c:1209: warning: passing argument 1 of 'dcr_map_mmio' > discards qualifiers from pointer target type > > This driver depends on PPC_DCR_NATIVE to be set for the relevant headers to be > included. Also if PPC_DCR_MMIO=n the build fails. So make PPC_DCR depend on > both > these options.
Um, NAK I think. The whole point is that some platforms implement DCR natively and some via MMIO, and that's meant to be hidden by the DCR API. If the driver is directly calling DCR native routines then it should depend on that. cheers _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
