On Wed, 2014-03-12 at 20:56 -0500, Zhao Qiang-B45475 wrote: > On Wed, 2014-03-13 at 2:46 AM, Scott wrote: > > > -----Original Message----- > > From: Wood Scott-B07421 > > Sent: Thursday, March 13, 2014 2:46 AM > > To: Zhao Qiang-B45475 > > Cc: linuxppc-dev@lists.ozlabs.org; Wood Scott-B07421; Xie Xiaobo-R63061 > > Subject: Re: [PATCH] T1040RDB: add qe node for T1040RDB dts > > > > On Wed, 2014-03-12 at 16:26 +0800, Zhao Qiang wrote: > > > Signed-off-by: Zhao Qiang <b45...@freescale.com> > > > --- > > > arch/powerpc/boot/dts/t1040rdb.dts | 43 > > > ++++++++++++++++++++++++++++++++++++++ > > > 1 file changed, 43 insertions(+) > > > > Presumably this is on top of this patch: > > http://patchwork.ozlabs.org/patch/314138/ > > > > ...since there's no existing t1040 device tree support. Always mention > > when your patch is on top of a patch that hasn't yet been merged and > > isn't in the same patch set. > > > > At least some of this stuff seems like it should be in t1040si-post.dts > > (or a file included by it), rather than the board dts. > > Every board can use ucc differently, It is not correct to put this node into > t1040si-post.dtsi. > For example t1040qds can use ucc1 to tdm while maybe t1040rdb use ucc1 to > uart.
That's why I said "some". :-) Anything that is specific to the board should be in the board file, but it's not clear that everything in this patch is board-specific. si/siram? Reg/ranges on the qe node? Etc. -Scott _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
