On Tue, 5 Nov 2013 16:16:08 Florian Fainelli wrote: [snip]
> 2013/11/5 Alistair Popple <alist...@popple.id.au>: > >> Any reasons why you are duplicating what is available in > >> drivers/of/of_net.c ::of_get_phy_mode()? > > > > Unless I'm missing something of_get_phy_mode() is going the other way. > > rgmii_mode_name() is converting PHY_MODE_* into a human-readable string. I > > couldn't find any obvious kernel method to do this but maybe I missed it? > > Right, rgmii_mode_name() just has informative purposes and should be > removed, I would suggest using standard device tree bindings property > (phy-mode) anyway such that you could use of_get_phy_mode() and use > phy_interface_t types. Ok, that's what is currently done in the core IBM EMAC driver. As this is used just for informative purposes I will remove it. Thanks. Regards, Alistair _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
