On Wed, 2013-09-18 at 05:43 +0000, Liu Shengzhou-B36685 wrote:
>
> > -----Original Message-----
> > From: Zhao Qiang-B45475
> > Sent: Wednesday, September 18, 2013 12:55 PM
> > To: linuxppc-dev@lists.ozlabs.org
> > Cc: Zhao Qiang-B45475; Liu Shengzhou-B36685
> > Subject: [PATCH v3] powerpc/p1010rdb-pb:make a new dts for p1010rdb-pb
> >
> > P1010RDB-PA and P1010RDB-PB boards use different external PHY interrupt
> > signals.
> > So make a new dts for P1010RDB-PB.
> >
> > Signed-off-by: Shengzhou Liu <shengzhou....@freescale.com>
> > Signed-off-by: Zhao Qiang <b45...@freescale.com>
> > ---
> > Changes for v2:
> > -Remove phy interrupts for p1010rdb-pb
> > Changes for v3:
> > -Maintain the phy interrupts p1010rdb-pa and make a new device
> > tree for p1010rdb-pb
> >
> > arch/powerpc/boot/dts/p1010rdb-pa.dtsi | 11 ++++++
> > arch/powerpc/boot/dts/p1010rdb-pb.dts | 67
> > ++++++++++++++++++++++++++++++++++
> > arch/powerpc/boot/dts/p1010rdb-pb.dtsi | 11 ++++++
> > arch/powerpc/boot/dts/p1010rdb.dts | 1 +
> > arch/powerpc/boot/dts/p1010rdb.dtsi | 3 --
> > arch/powerpc/platforms/85xx/p1010rdb.c | 29 +++++++++++++++
> > 6 files changed, 119 insertions(+), 3 deletions(-) create mode 100644
> > arch/powerpc/boot/dts/p1010rdb-pa.dtsi
> > create mode 100644 arch/powerpc/boot/dts/p1010rdb-pb.dts
> > create mode 100644 arch/powerpc/boot/dts/p1010rdb-pb.dtsi
> >
>
> Don't touch p1010rdb.c, create two p1010rdb-pa.dts and p1010rdb-pb.dts, which
> include the common p1010rdb.dtsi.
> Combine original p1010rdb.dts and p1010rdb.dtsi into new p1010rdb.dtsi with
> removing compatible part.
> Place phy node and following part in p1010rdb-pa.dts and p1010rdb-pb.dts.
> / {
> model = "fsl,P1010RDB-PA";
> compatible = "fsl,P1010RDB";
> }
>
> / {
> model = "fsl,P1010RDB-PB";
> compatible = "fsl,P1010RDB";
> }
Model is mainly for human consumption and generally redundant on the
toplevel node... These boards are obviously not fully compatible and
thus there should be a new "fsl,p1010rdb-pb" with the existing
"fsl,P1010RDB" used to refer to PA since we can't change it now.
-Scott
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
