On Mon, Jul 22, 2013 at 12:21:16PM +0530, Srivatsa S. Bhat wrote: > On 07/22/2013 12:10 PM, Chen Gang wrote: > > Since not need 'max_cpus' after the related commit, the related code > > are useless too, need be removed. > > > > The related commit: > > > > c1aa687 powerpc: Clean up obsolete code relating to decrementer and > > timebase > > > > The related warning: > > > > arch/powerpc/kernel/smp.c:323:43: warning: parameter ‘max_cpus’ set but > > not used [-Wunused-but-set-parameter] > > > > Signed-off-by: Chen Gang <gang.c...@asianux.com> > > This version looks good.
Agreed. A good follow up patch, or actually series of patches, would be to change the prototype of smp_ops->probe() to return void, and fix all the implementations to no longer return anything. cheers _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
