On 07/22/2013 12:10 PM, Chen Gang wrote: > Since not need 'max_cpus' after the related commit, the related code > are useless too, need be removed. > > The related commit: > > c1aa687 powerpc: Clean up obsolete code relating to decrementer and timebase > > The related warning: > > arch/powerpc/kernel/smp.c:323:43: warning: parameter ‘max_cpus’ set but not > used [-Wunused-but-set-parameter] > > Signed-off-by: Chen Gang <gang.c...@asianux.com>
This version looks good. Reviewed-by: Srivatsa S. Bhat <srivatsa.b...@linux.vnet.ibm.com> Regards, Srivatsa S. Bhat > --- > arch/powerpc/kernel/smp.c | 9 ++------- > 1 files changed, 2 insertions(+), 7 deletions(-) > > diff --git a/arch/powerpc/kernel/smp.c b/arch/powerpc/kernel/smp.c > index 38b0ba6..7edbd5b 100644 > --- a/arch/powerpc/kernel/smp.c > +++ b/arch/powerpc/kernel/smp.c > @@ -346,13 +346,8 @@ void __init smp_prepare_cpus(unsigned int max_cpus) > cpumask_set_cpu(boot_cpuid, cpu_sibling_mask(boot_cpuid)); > cpumask_set_cpu(boot_cpuid, cpu_core_mask(boot_cpuid)); > > - if (smp_ops) > - if (smp_ops->probe) > - max_cpus = smp_ops->probe(); > - else > - max_cpus = NR_CPUS; > - else > - max_cpus = 1; > + if (smp_ops && smp_ops->probe) > + smp_ops->probe(); > } > > void smp_prepare_boot_cpu(void) > _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
