-----Original Message----- From: Kumar Gala [mailto:ga...@kernel.crashing.org] Sent: Friday, April 05, 2013 12:44 AM To: Leekha Shaveta-B20052 Cc: linuxppc-dev@lists.ozlabs.org; Zhao Chenhui-B35336; Li Yang-R58472; Tang Yuantian-B29983; Sethi Varun-B16395; Lian Minghuan-B31939; Mehresh Ramneek-B31383; Fleming Andy-AFLEMING; Garg Vakul-B16394 Subject: Re: [PATCH 2/5] powerpc/fsl-booke: Add initial silicon device tree files for B4860 and B4420
On Apr 4, 2013, at 2:10 AM, Leekha Shaveta-B20052 wrote: > > > -----Original Message----- > From: Kumar Gala [mailto:ga...@kernel.crashing.org] > Sent: Wednesday, April 03, 2013 10:10 PM > To: Leekha Shaveta-B20052 > Cc: linuxppc-dev@lists.ozlabs.org; Zhao Chenhui-B35336; Li > Yang-R58472; Tang Yuantian-B29983; Sethi Varun-B16395; Lian > Minghuan-B31939; Mehresh Ramneek-B31383; Fleming Andy-AFLEMING; Garg > Vakul-B16394 > Subject: Re: [PATCH 2/5] powerpc/fsl-booke: Add initial silicon device > tree files for B4860 and B4420 > > > On Apr 2, 2013, at 2:16 AM, Shaveta Leekha wrote: > >> B4860 and B4420 are similar that share some commonalities >> >> * common features have been added in b4si-pre.dtsi and b4si-post.dtsi >> * differences are added in respective silicon files of B4860 and >> B4420 > > What are the differences between B4860 & B4420, beyond # of cores? > [SL] have detailed the differences in board support patch sent in this patch > set. > Do I need to mention the differences here also? > >> >> There are several things missing from the device trees of B4860 and B4420: >> >> * DPAA related nodes (Qman, Bman, Fman, Rman) >> * DSP related nodes/information > > What about: > > serdes, sfp [security fuse processor], thermal, gpio, maple, cpri, > quad timers, [SL] I would prefer to add, what have been added in > device tree so far in patch description As that is clear to me. > But as u suggested, I mentioned some of the nodes/things missing, > though the list is not Exhaustive. Also I am not sure of, what would be > added/required in future in these device tree files. > > Anyways, I can add all the things you have mentioned above. > Please tell if anything else is missing. I would add the trivial ones and just make sure the list is exhaustive for the ones missing in the commit message. [SL] Adding " serdes, sfp [security fuse processor], thermal, gpio, maple, cpri, quad timers as missing things" in my commit message. If I still miss some, Please add while applying the patch. Thanks, Shaveta > > Regards, > Shaveta > >> >> Signed-off-by: Shaveta Leekha <shav...@freescale.com> >> Signed-off-by: Zhao Chenhui <chenhui.z...@freescale.com> >> Signed-off-by: Li Yang <le...@freescale.com> >> Signed-off-by: Tang Yuantian <yuantian.t...@freescale.com> >> Signed-off-by: Varun Sethi <varun.se...@freescale.com> >> Signed-off-by: Minghuan Lian <minghuan.l...@freescale.com> >> Signed-off-by: Ramneek Mehresh <ramneek.mehr...@freescale.com> >> Signed-off-by: Kumar Gala <ga...@kernel.crashing.org> >> Signed-off-by: Andy Fleming <aflem...@freescale.com> >> Signed-off-by: Vakul Garg <va...@freescale.com> >> --- >> arch/powerpc/boot/dts/fsl/b4420si-post.dtsi | 94 ++++++++++ >> arch/powerpc/boot/dts/fsl/b4420si-pre.dtsi | 49 +++++ >> arch/powerpc/boot/dts/fsl/b4860si-post.dtsi | 138 ++++++++++++++ >> arch/powerpc/boot/dts/fsl/b4860si-pre.dtsi | 59 ++++++ >> arch/powerpc/boot/dts/fsl/b4si-post.dtsi | 262 >> +++++++++++++++++++++++++++ >> arch/powerpc/boot/dts/fsl/b4si-pre.dtsi | 65 +++++++ > > Remove b4si-pre.dtsi, there isn't enough here to warrant not just > merging it into b4420si-pre.dtsi & b4860si-pre.dtsi > - k _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
