Dear Doug Anderson, > There is simply no reason to be manually setting the private driver > data to NULL in the remove/fail to probe cases. This is just extra > cruft code that can be removed. > > A few notes: > * Nothing relies on drvdata being set to NULL. > * The __device_release_driver() function eventually calls > dev_set_drvdata(dev, NULL) anyway, so there's no need to do it > twice. > * I verified that there were no cases where xxx_get_drvdata() was > being called in these drivers and checking for / relying on the NULL > return value. > > This could be cleaned up kernel-wide but for now just take the baby > step and remove from the i2c subsystem. > > Reported-by: Wolfram Sang <w...@the-dreams.de> > Reported-by: Stephen Warren <swar...@wwwdotorg.org> > Signed-off-by: Doug Anderson <diand...@chromium.org>
For > drivers/i2c/busses/i2c-mxs.c | 2 -- [...] > diff --git a/drivers/i2c/busses/i2c-mxs.c b/drivers/i2c/busses/i2c-mxs.c > index 22d8ad3..120f246 100644 > --- a/drivers/i2c/busses/i2c-mxs.c > +++ b/drivers/i2c/busses/i2c-mxs.c > @@ -697,8 +697,6 @@ static int mxs_i2c_remove(struct platform_device *pdev) > > writel(MXS_I2C_CTRL0_SFTRST, i2c->regs + MXS_I2C_CTRL0_SET); > > - platform_set_drvdata(pdev, NULL); > - > return 0; > } [...] Add my: Reviewed-by: Marek Vasut <ma...@denx.de> _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
