Scott Wood wrote: >> > + compatible = "fsl,p5040-pcie", "fsl,qoriq-pcie-v2.2"; > p5040 has PCIe v2.4. > > Note that there is a version register, so perhaps we should drop the > version number from the compatible (and mention the version register in > the binding). > > Might want to double check the other version numbers in this file too.
It appears that this compatible string is used by U-Boot to find the nodes for fixups: #elif defined(CONFIG_PPC_P5040) #define CONFIG_MAX_CPUS 4 ... #define CONFIG_SYS_FSL_PCIE_COMPAT "fsl,qoriq-pcie-v2.2" Which means that I can't just change it from v2.2 to v2.4 without breaking U-Boot. Ugh. How do you know that the P5040 has v2.4? -- Timur Tabi Linux kernel developer at Freescale _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
