On Wed, 17 Aug 2011 05:46:29 +0800, Scott Wood <scottw...@freescale.com>
wrote:
On 08/16/2011 04:27 AM, Chunhe Lan wrote:
Nand flash nodes with the property status="disabled" are not
usable and so avoid adding "disabled" nand flash devices with
the system.
Signed-off-by: Chunhe Lan <chunhe....@freescale.com>
---
drivers/mtd/nand/fsl_elbc_nand.c | 5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/drivers/mtd/nand/fsl_elbc_nand.c
b/drivers/mtd/nand/fsl_elbc_nand.c
index 33d8aad..8212c12 100644
--- a/drivers/mtd/nand/fsl_elbc_nand.c
+++ b/drivers/mtd/nand/fsl_elbc_nand.c
@@ -1,6 +1,6 @@
/* Freescale Enhanced Local Bus Controller NAND driver
*
- * Copyright © 2006-2007, 2010 Freescale Semiconductor
+ * Copyright © 2006-2007, 2010-2011 Freescale Semiconductor
*
* Authors: Nick Spence <nick.spe...@freescale.com>,
* Scott Wood <scottw...@freescale.com>
@@ -849,6 +849,9 @@ static int __devinit fsl_elbc_nand_probe(struct
platform_device *pdev)
struct device *dev;
struct device_node *node = pdev->dev.of_node;
+ if (!of_device_is_available(node))
+ return -ENODEV;
+
if (!fsl_lbc_ctrl_dev || !fsl_lbc_ctrl_dev->regs)
return -ENODEV;
lbc = fsl_lbc_ctrl_dev->regs;
Same comment as the other patch -- unavailable devices should already
not be getting probed. Also, this subject line makes it sound like this
is a NAND subsystem change rather than a change in one specific driver.
You are right.
The upper layers have prevented unavailable devices.
So, this patch is no need.
Thanks.
-Jack Lan
-Scott
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
