On 5/21/11, Segher Boessenkool <[email protected]> wrote: >> If second CPU is not enabled, CPC925 EDAC driver will spill out >> warnings >> about errors on second Processor Interface. Support masking that out, >> by detecting at runtime which CPUs are present in device tree. > > That doesn't quite work, there can be multiple CPUs per processor > interface.
Are you sure that there can be multiple CPUs on one PI with CPC925 (CPC945 isn't supported by this driver anyway, IIUC). > You should be able to see which interfaces are enabled in some CPC925 > register, > but maybe both _are_ enabled on your system (although one is not > connected), > which is causing the errors? Hmm, I dont't think this is the case: I'm using a MapleD board with two CPUs connected to separate PIs. However I can slect the service processor to enable only one CPU via selecting correct bootscript. In this case bootscript correctly enables only APIMASK_ADI0. However as cpc925_edac checks the APIEXCP itself, it sees the APIEXCP_ADI1 bit set and spills regular warnings about it (see below). If you'd prefer I can add a check for APIMASK at cpc925_cpu_init() time, but I think that this will be less robust. -- With best wishes Dmitry _______________________________________________ Linuxppc-dev mailing list [email protected] https://lists.ozlabs.org/listinfo/linuxppc-dev
