On Mon, 2011-02-07 at 16:10 +1100, Benjamin Herrenschmidt wrote:
> On Wed, 2011-01-05 at 16:44 -0600, Tseng-Hui (Frank) Lin wrote:
> > This patch adds support for handling IO Event interrupts which come
> > through at the /event-sources/ibm,io-events device tree node.
>
> .../...
>
> The previous patches regarding the error log sometimes call it error log
> and sometimes event log. Can you consolidate that ?
Sure. The top level of the RTAS error/event log is for both error and
event. Starting V6 extension, they should be all event.
>
> > +int pseries_ioei_register_handler(pseries_ioei_handler_t handler)
> > +{
>
> Shouldn't we have a void * to attach with each client so it can put
> its private data there and get them back in the handler ?
Although not used at this moment, this is a good idea. Will add private
data.
> We are -really- re-inventing interrupts and/or notifiers here, which
> I find a tad annoying..
Agree. This is ugly. We could have just used the regular interrupt
mechanism if the firmware didn't use shared rtas call and interrupt
to report multiple types of events.
>
> Cheers,
> Ben.
>
>
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
