On Wed, 2011-01-05 at 16:44 -0600, Tseng-Hui (Frank) Lin wrote:
> This patch adds support for handling IO Event interrupts which come
> through at the /event-sources/ibm,io-events device tree node.

 .../...

The previous patches regarding the error log sometimes call it error log
and sometimes event log. Can you consolidate that ?

> +int pseries_ioei_register_handler(pseries_ioei_handler_t handler)
> +{

Shouldn't we have a void * to attach with each client so it can put
its private data there and get them back in the handler ?

We are -really- re-inventing interrupts and/or notifiers here, which
I find a tad annoying..

Cheers,
Ben.


_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

Reply via email to