On Wed, Aug 18, 2010 at 02:31:42PM -0500, Timur Tabi wrote: > On Tue, Jun 8, 2010 at 2:55 PM, Anton Vorontsov <avoront...@mvista.com> wrote: > > The mpc85xx_mds_setup_arch() function is incomprehensible > > and unmaintainable. Factor out all QE specific stuff into > > mpc85xx_mds_qe_init() and mpc85xx_mds_reset_ucc_phys(). > > > > Also move QE stuff out of mpc85xx_mds_pic_init(). > > > > The diff is unreadable, but only because the code was so. ;-) > > It should be better now, and less indented. > > > > Signed-off-by: Anton Vorontsov <avoront...@mvista.com> > > --- > > This patch introduces breaks mpc85xx_smp_defconfig: > > CC arch/powerpc/platforms/85xx/mpc85xx_mds.o > arch/powerpc/platforms/85xx/mpc85xx_mds.c: In function > 'mpc85xx_mds_setup_arch': > arch/powerpc/platforms/85xx/mpc85xx_mds.c:367: error: 'np' undeclared > (first use in this function) > arch/powerpc/platforms/85xx/mpc85xx_mds.c:367: error: (Each undeclared > identifier is reported only once > arch/powerpc/platforms/85xx/mpc85xx_mds.c:367: error: for each > function it appears in.)
Thanks for the report, apparently I tested my patch without CONFIG_PCI... But the issue should be already fixed by powerpc/85xx: Fix compile error in mpc85xx_mds.c http://patchwork.ozlabs.org/patch/60933/ (Though, not in Linus' tree yet.) Thanks, -- Anton Vorontsov email: cbouatmai...@gmail.com irc://irc.freenode.net/bd2 _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
