On Tue, Jun 8, 2010 at 2:55 PM, Anton Vorontsov <avoront...@mvista.com> wrote: > The mpc85xx_mds_setup_arch() function is incomprehensible > and unmaintainable. Factor out all QE specific stuff into > mpc85xx_mds_qe_init() and mpc85xx_mds_reset_ucc_phys(). > > Also move QE stuff out of mpc85xx_mds_pic_init(). > > The diff is unreadable, but only because the code was so. ;-) > It should be better now, and less indented. > > Signed-off-by: Anton Vorontsov <avoront...@mvista.com> > ---
This patch introduces breaks mpc85xx_smp_defconfig: CC arch/powerpc/platforms/85xx/mpc85xx_mds.o arch/powerpc/platforms/85xx/mpc85xx_mds.c: In function 'mpc85xx_mds_setup_arch': arch/powerpc/platforms/85xx/mpc85xx_mds.c:367: error: 'np' undeclared (first use in this function) arch/powerpc/platforms/85xx/mpc85xx_mds.c:367: error: (Each undeclared identifier is reported only once arch/powerpc/platforms/85xx/mpc85xx_mds.c:367: error: for each function it appears in.) Frankly, I've been seeing a lot of build breaks with mpc85xx_[smp_]defconfig. I had a patch that added a p1022_ds_defconfig, but was told instead to update mpc85xx_[smp_]defconfig. However, it appears that no one is really testing mpc85xx_[smp_]defconfig, since there are now *two* failures (this one, and CONFIG_RAPIDIO) with these defconfig files. -- Timur Tabi Linux kernel developer at Freescale _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
