There was no way to set mapped memory as cacheable if the memory
is not managed by Linux kernel. It's not rare in real system to
allocate some dedicated memory to a certain application which is not
managed by kernel and then mmap'ed the memory to the application.
The memory should be cacheable but we can't map it to be cacheable
due to the intelligent setting of cacheability.
The patch makes the cacheability depend on O_SYNC flag of the file
mapped for non-kernel managed memory. Also prints a deprecation
warning for mmap users without using O_SYNC.
Signed-off-by: Li Yang <le...@freescale.com>
---
arch/powerpc/mm/mem.c | 13 +++++++++++--
1 files changed, 11 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/mm/mem.c b/arch/powerpc/mm/mem.c
index 579382c..b9ef77a 100644
--- a/arch/powerpc/mm/mem.c
+++ b/arch/powerpc/mm/mem.c
@@ -101,8 +101,17 @@ pgprot_t phys_mem_access_prot(struct file *file, unsigned
long pfn,
if (ppc_md.phys_mem_access_prot)
return ppc_md.phys_mem_access_prot(file, pfn, size, vma_prot);
- if (!page_is_ram(pfn))
- vma_prot = pgprot_noncached(vma_prot);
+ /* kernel managed memory is always cacheable, otherwise is controlled
+ * by O_SYNC flag of open() */
+ if (!page_is_ram(pfn)) {
+ if (file->f_flags & O_SYNC)
+ vma_prot = pgprot_noncached(vma_prot);
+ else
+ printk(KERN_WARNING
+ "Warning: mmap on file without O_SYNC will be "
+ "mapped as cacheable. Make sure it is desired."
+ "\n");
+ }
return vma_prot;
}
--
1.6.4
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
