On Fri, Nov 13, 2009 at 4:10 AM, Wolfram Sang <w.s...@pengutronix.de> wrote: > On Fri, Nov 13, 2009 at 11:41:17AM +0100, Luotao Fu wrote: >> This one enables the mpc52xx_spi driver for usage of user defined gpio lines >> as chipselect. This way we can control some more spi devices than only one >> >> V2 Changes: >> * preinitialize the gpio as output in probe function and call gpio_set_value >> in >> the chip select function instead of calling direction_output every time. >> * initialize the gpio line with output high, since we don't support CS_HIGH >> in the driver currently any way. change gpio value setting to default >> active >> low in chip select call. >> * free the gpio array while error or removing. >> >> Signed-off-by: Luotao Fu <l...@pengutronix.de>
>> @@ -477,6 +520,12 @@ static int __devinit mpc52xx_spi_probe(struct of_device >> *op, >> err_register: >> dev_err(&ms->master->dev, "initialization failed\n"); >> spi_master_put(master); >> + err_gpio: >> + while (i-- > 0) >> + gpio_free(ms->gpio_cs[i]); >> + >> + if (ms->gpio_cs != NULL) >> + kfree(ms->gpio_cs); > > kfree() is NULL aware, so no if needed. Not dangerous though. No need to respin just for this. g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
