On Wed, Oct 14, 2009 at 09:41:33AM +0200, Richard Cochran wrote: > >-----Original Message----- > >From: linuxppc-dev-bounces On Behalf Of Scott Wood > >Sent: Wednesday, September 09, 2009 8:22 PM > >To: Roland Lezuo > >Cc: linuxppc-dev@lists.ozlabs.org > >Subject: Re: [PATCH] * mpc8313erdb.dts: Fixed eTSEC interrupt assignment. > > > >On Fri, Sep 04, 2009 at 12:31:25PM +0200, Roland Lezuo wrote: > >> The following patch is needed to correctly assign the IRQs for the > >> gianfar driver on the MPC8313ERDB-revc boards. ERR and TX are swapped > >> as well as the interrupt lines for the two devices. > > > >And it will incorrectly assign them on older revisions of the chip. > > > >We really should have a u-boot fixup based on SVR. > > Why not just offer different dts files, one for each board revision? > > Something like: > mpc8313erdb-revA.dts > mpc8313erdb-revB.dts > mpc8313erdb-revC.dts
Because that would be three times the device trees to maintain, and a source of user confusion. -Scott _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
