On Tue, May 26, 2009 at 10:42:05AM +0100, Arnd Bergmann wrote: > On Tuesday 26 May 2009, David Miller wrote: > > It's such a baroque thing, there is no reason to set it at all if you > > ask me. It's only use is to allow ISA and similar primitive bus > > devices to have their I/O ports changed via ifconfig. > > My original comment was about the fact that sja1000 was doing > dev->base_addr = (unsigned long)ioremap(phys_addr, size), I didn't > even think about SIOCGIFMAP and command line overrides, but that > surely makes it worse and the driver should be changed to > store the virtual register address in its private data structure. > > drivers/net/fec.c seems to have the same problem, which manifests > in a number of ugly casts and direct pointer dereferences in places > where it should do writel() or out_be32().
Ack. I'll prepare a patch for fec.c. Internally the driver already uses a void __iomem * and writel/readl in -next. There is only one usage left. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
