Hello,
Your patch is word-wrapped. It also lacks the Signed-off-by tag, which
is required.
I apologize please see an updated patch below.
The changelog sounds as if there are bugs being fixed here, but really
you're adding support for something entirely new. The yosemite board
comes with U-Boot, which uses uImages. You seem to be adding support
for using simpleboot on the Yosemite board. Is that correct?
Yes, the patch ensures the simpleboot image works on the Yosemite board. I was
under the impression the code was broken as one can build a simpleImage for the
Yosemite board as described in Documentation/powerpc/bootwrapper.txt without any
modification on a vanilla kernel, although the resulting image does not work
without the following patches.
> You can't do this. If you hard code the MAC address of whatever board
> you are using in the kernel, everyone will have to edit it. You need
> to specify this in your board DTS file or via some other configurable
> mechansim.
Oops, sorry I forgot to pull out the debug code...
Signed-off-by: Eddie Dawydiuk <ed...@embeddedarm.com>
diff -urN linux-2.6.28.orig/arch/powerpc/boot/Makefile
linux-2.6.28/arch/powerpc/boot/Makefile
--- linux-2.6.28.orig/arch/powerpc/boot/Makefile 2008-12-24
16:26:37.000000000 -0700
+++ linux-2.6.28/arch/powerpc/boot/Makefile 2009-03-05 17:35:53.000000000
-0700
@@ -70,7 +70,7 @@
cuboot-katmai.c cuboot-rainier.c redboot-8xx.c ep8248e.c \
cuboot-warp.c cuboot-85xx-cpm2.c cuboot-yosemite.c simpleboot.c
\
virtex405-head.S virtex.c redboot-83xx.c cuboot-sam440ep.c \
- cuboot-acadia.c
+ cuboot-acadia.c simpleboot-yosemite.c
src-boot := $(src-wlib) $(src-plat) empty.c
src-boot := $(addprefix $(obj)/, $(src-boot))
@@ -224,7 +224,7 @@
image-$(CONFIG_TAISHAN) += cuImage.taishan
image-$(CONFIG_KATMAI) += cuImage.katmai
image-$(CONFIG_WARP) += cuImage.warp
-image-$(CONFIG_YOSEMITE) += cuImage.yosemite
+image-$(CONFIG_YOSEMITE) += cuImage.yosemite simpleImage.yosemite
# Board ports in arch/powerpc/platform/8xx/Kconfig
image-$(CONFIG_MPC86XADS)
diff -urN linux-2.6.28.orig/arch/powerpc/boot/wrapper
linux-2.6.28/arch/powerpc/boot/wrapper
--- linux-2.6.28.orig/arch/powerpc/boot/wrapper 2008-12-24 16:26:37.000000000
-0700
+++ linux-2.6.28/arch/powerpc/boot/wrapper 2009-03-05 17:36:10.000000000
-0700
@@ -214,8 +214,12 @@
platformo="$object/simpleboot.o $object/virtex.o"
binary=y
;;
+simpleboot-yosemite)
+ platformo="$object/fixed-head.o $object/simpleboot.o
$object/simpleboot-yosemite.o"
+ binary=y
+ ;;
simpleboot-*)
- platformo="$object/simpleboot.o"
+ platformo="$object/fixed-head.o $object/simpleboot.o"
binary=y
;;
asp834x-redboot)
diff -urN linux-2.6.28.orig/arch/powerpc/boot/simpleboot-yosemite.c
linux-2.6.28/arch/powerpc/boot/simpleboot-yosemite.c
--- linux-2.6.28.orig/arch/powerpc/boot/simpleboot-yosemite.c 1969-12-31
17:00:00.000000000 -0700
+++ linux-2.6.28/arch/powerpc/boot/simpleboot-yosemite.c 2009-03-06
14:55:46.000000000 -0700
@@ -0,0 +1,24 @@
+#include "ops.h"
+#include "stdio.h"
+#include "4xx.h"
+#include "44x.h"
+
+#define TARGET_4xx
+#define TARGET_44x
+#include "ppcboot.h"
+
+static void yosemite_fixups(void)
+{
+ unsigned long sysclk = 50000000;
+
+ ibm440ep_fixup_clocks(sysclk, 11059200, 400000000);
+ ibm4xx_sdram_fixup_memsize();
+ dt_fixup_mac_address_by_alias("ethernet0", eth0adr);
+ dt_fixup_mac_address_by_alias("ethernet1", eth1adr);
+}
+
+void platform_specific_init(void)
+{
+ platform_ops.fixups = yosemite_fixups;
+ platform_ops.exit = ibm44x_dbcr_reset;
+}
--
Best Regards,
________________________________________________________________
Eddie Dawydiuk, Technologic Systems | voice: (480) 837-5200
16525 East Laser Drive | fax: (480) 837-5300
Fountain Hills, AZ 85268 | web: www.embeddedARM.com
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev