From: Da Yu <d...@datangmobile.cn>
Date: Wed, 18 Feb 2009 19:58:20 +0800
Subject: [PATCH] fix the interrupt loss problem on powerpc IPIC (2.6.25-2.6.28)
Signed-off-by: Da Yu <d...@datangmobile.cn>
---
--- a/arch/powerpc/sysdev/ipic.c 2009-02-18 09:47:04.000000000 +0800
+++ b/arch/powerpc/sysdev/ipic.c 2009-02-18 09:46:34.000000000 +0800
@@ -568,8 +568,7 @@ static void ipic_ack_irq(unsigned int vi
spin_lock_irqsave(&ipic_lock, flags);
- temp = ipic_read(ipic->regs, ipic_info[src].ack);
- temp |= (1 << (31 - ipic_info[src].bit));
+ temp = 1 << (31 - ipic_info[src].bit);
ipic_write(ipic->regs, ipic_info[src].ack, temp);
/* mb() can't guarantee that ack is finished. But it does finish
@@ -592,8 +591,7 @@ static void ipic_mask_irq_and_ack(unsign
temp &= ~(1 << (31 - ipic_info[src].bit));
ipic_write(ipic->regs, ipic_info[src].mask, temp);
- temp = ipic_read(ipic->regs, ipic_info[src].ack);
- temp |= (1 << (31 - ipic_info[src].bit));
+ temp = 1 << (31 - ipic_info[src].bit);
ipic_write(ipic->regs, ipic_info[src].ack, temp);
/* mb() can't guarantee that ack is finished. But it does finish
-----邮件原件-----
发件人: Li Yang [mailto:le...@freescale.com]
发送时间: 2009年2月17日 22:38
收件人: Kumar Gala
抄送: 笪禹; linux-ker...@vger.kernel.org; linuxppc-dev@ozlabs.org
主题: Re: [PATCH] fix the interrupt loss problem on powerpc IPIC (2.6.23)
On Tue, Feb 17, 2009 at 10:12 PM, Kumar Gala <ga...@kernel.crashing.org> wrote:
>
> On Feb 17, 2009, at 6:44 AM, <d...@datangmobile.cn>
> <d...@datangmobile.cn>
> wrote:
>
>> From: Da Yu <d...@datangmobile.cn>
>> Date: Tue, 17 Feb 2009 19:58:20 +0800
>> Subject: [PATCH] fix the interrupt loss problem on powerpc IPIC
>> (2.6.23)
>>
>> Signed-off-by: Da Yu <d...@datangmobile.cn>
>> ---
>
> Please provide a bit more description as to why this fixes the issue.
The pending register is write 1 clear. If there are more than one external
interrupts pending at the same time, acking the first interrupt will also clear
other interrupt pending bits. That will cause loss of interrupt.
- Leo
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
