On Tue, 2009-02-10 at 13:12 -0800, Mike Mason wrote: > I'm resubmitting this patch with a couple changes > suggested by Michael Ellerman. 1) the new functions > should be static, and 2) some people may object to > including unrelated formating changes. > > ========================================================= > > The EEH code disables and enables interrupts during the > device recovery process. This is unnecessary for MSI > and MSI-X interrupts because they are effectively disabled > by the DMA Stopped state when an EEH error occurs. The > current code is also incorrect for MSI-X interrupts. It > doesn't take into account that MSI-X interrupts are tracked > in a different way than LSI/MSI interrupts. This patch > ensures only LSI interrupts are disabled/enabled. > > Signed-off-by: Mike Mason <mm...@us.ibm.com> > Acked-by: Linas Vepstas <linasveps...@gmail.com>
Looks good. Assuming you've tested it :) Acked-by: Michael Ellerman <mich...@ellerman.id.au> -- Michael Ellerman OzLabs, IBM Australia Development Lab wwweb: http://michael.ellerman.id.au phone: +61 2 6212 1183 (tie line 70 21183) We do not inherit the earth from our ancestors, we borrow it from our children. - S.M.A.R.T Person
signature.asc
Description: This is a digitally signed message part
_______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
