On Tue, 2009-02-10 at 11:14 -0600, Linas Vepstas wrote: > 2009/2/9 Mike Mason <mm...@us.ibm.com>: > > The EEH code disables and enables interrupts during the > > device recovery process. This is unnecessary for MSI > > and MSI-X interrupts because they are effectively disabled > > by the DMA Stopped state when an EEH error occurs. The current code is also > > incorrect for MSI-X interrupts. It > > doesn't take into account that MSI-X interrupts are tracked > > in a different way than LSI/MSI interrupts. This patch ensures only LSI > > interrupts are disabled/enabled. > > > > The patch also includes a couple minor formatting fixes. > > > > > > Signed-off-by: Mike Mason <mm...@us.ibm.com> > > Looks good to me. > Acked-by: Linas Vepstas <linasveps...@gmail.com> > > On a somewhat-related note: there was an issue (I forget > the details) where the kernel needed to shadow some sort > of MSI state so that it could be correctly, um, kept-track-of, > after an EEH reset (it didn't need to be restored, because > firmware did this(?)). After some digging around and > discussion, we concluded that some generic PPC MSI > code needed to be altered to track this state, and/or > the main kernel MSI code needed to be changed to > (not?) track this state. Mike Ellerman seemed to best > grasp this area ... was this ever fixed? > > Or perhaps this is an alternate fix for that bug? It may > well have been that calling the MSI disable triggered > the problem, I don't remember now.
I'm pretty sure you're referring to this patch, which you acked :) http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=1db3e890aed3ac39cded30d6e94618bda086f7ce I don't know of anything else that fits your description? cheers -- Michael Ellerman OzLabs, IBM Australia Development Lab wwweb: http://michael.ellerman.id.au phone: +61 2 6212 1183 (tie line 70 21183) We do not inherit the earth from our ancestors, we borrow it from our children. - S.M.A.R.T Person
signature.asc
Description: This is a digitally signed message part
_______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
