On Sun, 19 Oct 2008, Jon Smirl wrote:
> i2c-mpc.c has:
>
> static const struct of_device_id mpc_i2c_of_match[] = {
> {.compatible = "fsl-i2c",},
> {},
> };
> MODULE_DEVICE_TABLE(of, mpc_i2c_of_match);
>
>
> /* Structure for a device driver */
> static struct of_platform_driver mpc_i2c_driver = {
> .match_table = mpc_i2c_of_match,
> .probe = fsl_i2c_probe,
> .remove = __devexit_p(fsl_i2c_remove),
> .driver = {
> .owner = THIS_MODULE,
> .name = DRV_NAME,
> },
> };
>
> That should match:
>
> [EMAIL PROTECTED] {
> #address-cells = <1>;
> #size-cells = <0>;
> cell-index = <0>;
> compatible = "fsl-i2c";
> reg = <0x80003000 0x1000>;
> interrupts = <5 2>;
> interrupt-parent = <&mpic>;
>
> [EMAIL PROTECTED] {
> device_type = "rtc";
> compatible = "ricoh,rs5c372a";
> reg = <0x32>;
> };
> };
It should, but it doesn't.
> This code works on my mpc5200 board.
Don't know which 5200 board you have, but, for example lite5200 has
compatible = "fsl,mpc5200-i2c","fsl-i2c";
see the difference?
> Maybe fsl_i2c_probe() is failing?
It has a printk at each error case (ok, except kzalloc, but I don't think
that is the case), I see none of them.
> Add some printks in i2c-mpc to help debug the problem.
> Any errors from i2c-mpc in dmesg?
None, and, as I said, there are no error messages from it, so, it doesn't
get called at all. To be quite sure I added a printk at the entry - as
expected it didn't get printed.
Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
