On 11. 06. 25, 17:12, Andy Shevchenko wrote:
On Wed, Jun 11, 2025 at 12:02:54PM +0200, Jiri Slaby (SUSE) wrote:
uart_port::{serial_in,serial_out} (and plat_serial8250_port::* likewise)
historically use:
* 'unsigned int' for 32-bit register values in reads and writes, and
* 'int' for offsets.
Make them sane such that:
* 'u32' is used for register values, and
* 'unsigned int' is used for offsets.
While at it, name hooks' parameters, so it is clear what is what.
At a glance this looks just mechanical change. Have you used coccinelle for
that?
No, I haven't managed to learn that :P. But I used
https://github.com/jirislaby/clang-struct.
thanks,
--
js
suse labs
