On 2/24/25 17:31, Christophe Leroy wrote:
>
>
> Le 17/02/2025 à 05:22, Anshuman Khandual a écrit :
>> Platforms subscribe into generic ptdump implementation via GENERIC_PTDUMP.
>> But generic ptdump gets enabled via PTDUMP_CORE. These configs combination
>> is confusing as they sound very similar and does not differentiate between
>> platform's feature subscription and feature enablement for ptdump. Rename
>> the configs as ARCH_HAS_PTDUMP and PTDUMP making it more clear and improve
>> readability.
>>
>> Cc: Catalin Marinas <catalin.mari...@arm.com>
>> Cc: Will Deacon <w...@kernel.org>
>> Cc: Jonathan Corbet <cor...@lwn.net>
>> Cc: Marc Zyngier <m...@kernel.org>
>> Cc: Michael Ellerman <m...@ellerman.id.au>
>> Cc: Nicholas Piggin <npig...@gmail.com>
>> Cc: Paul Walmsley <paul.walms...@sifive.com>
>> Cc: Palmer Dabbelt <pal...@dabbelt.com>
>> Cc: Heiko Carstens <h...@linux.ibm.com>
>> Cc: Vasily Gorbik <g...@linux.ibm.com>
>> Cc: Thomas Gleixner <t...@linutronix.de>
>> Cc: Ingo Molnar <mi...@redhat.com>
>> Cc: Andrew Morton <a...@linux-foundation.org>
>> Cc: linux-arm-ker...@lists.infradead.org
>> Cc: linux-...@vger.kernel.org
>> Cc: linux-ker...@vger.kernel.org
>> Cc: kvm...@lists.linux.dev
>> Cc: linuxppc-dev@lists.ozlabs.org
>> Cc: linux-ri...@lists.infradead.org
>> Cc: linux-s...@vger.kernel.org
>> Cc: linux...@kvack.org
>> Signed-off-by: Anshuman Khandual <anshuman.khand...@arm.com>
>> ---
>> diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig
>> index 7612c52e9b1e..5aef2aa4103c 100644
>> --- a/arch/riscv/Kconfig
>> +++ b/arch/riscv/Kconfig
>> @@ -43,6 +43,7 @@ config RISCV
>> select ARCH_HAS_PMEM_API
>> select ARCH_HAS_PREEMPT_LAZY
>> select ARCH_HAS_PREPARE_SYNC_CORE_CMD
>> + select ARCH_HAS_PTDUMP
>
> Is it OK to drop the 'if MMU' from below ?
Sure, will add it back.
>
>> select ARCH_HAS_PTE_DEVMAP if 64BIT && MMU
>> select ARCH_HAS_PTE_SPECIAL
>> select ARCH_HAS_SET_DIRECT_MAP if MMU
>> @@ -112,7 +113,6 @@ config RISCV
>> select GENERIC_IRQ_SHOW_LEVEL
>> select GENERIC_LIB_DEVMEM_IS_ALLOWED
>> select GENERIC_PCI_IOMAP
>> - select GENERIC_PTDUMP if MMU
>> select GENERIC_SCHED_CLOCK
>> select GENERIC_SMP_IDLE_THREAD
>> select GENERIC_TIME_VSYSCALL if MMU && 64BIT
