Hello Russell, On Thu, 7 Nov 2024 17:51:05 +0000 "Russell King (Oracle)" <li...@armlinux.org.uk> wrote:
> On Thu, Nov 07, 2024 at 06:02:49PM +0100, Maxime Chevallier wrote: > > Preparing the phylink conversion, split the adjust_link callbaclk, by > > clearly separating the mac configuration, link_up and link_down phases. > > I'm not entirely sure what the point of this patch is, given that in > patch 7, all this code gets deleted, or maybe moved? > > If it's moved, it may be better in patch 7 to ensure that doesn't > happen, and move it in a separate patch - right now patch 7 is horrible > to review as there's no way to see what the changes are in these > link_up()/link_down() functions. I agree that it's hard to review indeed... I followed the documented approach of splitting-up the adjust_link callback then performing the conversion, but it's true that it doesn't really make patch 7 more readable. I can try to move things around and make patch 7 a bit more straightforward. Thanks, Maxime
