On Thu, Nov 07, 2024 at 06:02:49PM +0100, Maxime Chevallier wrote: > Preparing the phylink conversion, split the adjust_link callbaclk, by > clearly separating the mac configuration, link_up and link_down phases.
I'm not entirely sure what the point of this patch is, given that in patch 7, all this code gets deleted, or maybe moved? If it's moved, it may be better in patch 7 to ensure that doesn't happen, and move it in a separate patch - right now patch 7 is horrible to review as there's no way to see what the changes are in these link_up()/link_down() functions. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
