On 9/5/24 10:26 AM, Jarkko Sakkinen wrote:
On Thu Sep 5, 2024 at 11:52 AM EEST, Kexy Biscuit wrote:
Commit 08d08e2e9f0a ("tpm: ibmvtpm: Call tpm2_sessions_init() to
initialize session support") adds call to tpm2_sessions_init() in ibmvtpm,
which could be built as a module. However, tpm2_sessions_init() wasn't
exported, causing libmvtpm to fail to build as a module:
ERROR: modpost: "tpm2_sessions_init" [drivers/char/tpm/tpm_ibmvtpm.ko]
undefined!
Export tpm2_sessions_init() to resolve the issue.
Cc: sta...@vger.kernel.org # v6.10+
Reported-by: kernel test robot <l...@intel.com>
Closes:
https://lore.kernel.org/oe-kbuild-all/202408051735.zjkapq3b-...@intel.com/
Fixes: 08d08e2e9f0a ("tpm: ibmvtpm: Call tpm2_sessions_init() to initialize session
support")
Signed-off-by: Kexy Biscuit <kexybisc...@aosc.io>
Signed-off-by: Mingcong Bai <jeff...@aosc.io>
---
V1 -> V2: Added Fixes tag and fixed email format
RESEND: The previous email was sent directly to stable-rc review
drivers/char/tpm/tpm2-sessions.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/char/tpm/tpm2-sessions.c b/drivers/char/tpm/tpm2-sessions.c
index d3521aadd43e..44f60730cff4 100644
--- a/drivers/char/tpm/tpm2-sessions.c
+++ b/drivers/char/tpm/tpm2-sessions.c
@@ -1362,4 +1362,5 @@ int tpm2_sessions_init(struct tpm_chip *chip)
return rc;
}
+EXPORT_SYMBOL(tpm2_sessions_init);
#endif /* CONFIG_TCG_TPM2_HMAC */
Reviewed-by: Jarkko Sakkinen <jar...@kernel.org>
Would have tested it but machine is down..
Reviewed-by: Stefan Berger <stef...@linux.ibm.com>
BR, Jarkko
