Re: [PATCH 14/26] block: move the nonrot flag to queue_limits

[Simon Fernandez]

Hi folks, how can I unsubscribe from this group.?
Thanks in advance.
S

> On 24 Jun 2024, at 18:08, Keith Busch <kbu...@kernel.org> wrote:
> 
> On Mon, Jun 17, 2024 at 08:04:41AM +0200, Christoph Hellwig wrote:
>> -#define blk_queue_nonrot(q) test_bit(QUEUE_FLAG_NONROT, &(q)->queue_flags)
>> +#define blk_queue_nonrot(q) ((q)->limits.features & BLK_FEAT_ROTATIONAL)
> 
> This is inverted. Should be:
> 
> #define blk_queue_nonrot(q)   (!((q)->limits.features & BLK_FEAT_ROTATIONAL))
>