On Mon, Mar 04, 2024 at 09:03:34AM -0400, Jason Gunthorpe wrote:
> On Thu, Feb 29, 2024 at 04:42:55PM +0800, pet...@redhat.com wrote:
> > From: Peter Xu <pet...@redhat.com>
> >
> > pud_leaf() has a fallback macro defined in include/linux/pgtable.h already.
> > Drop the extra two for x86.
> >
> > Cc: Thomas Gleixner <t...@linutronix.de>
> > Cc: Ingo Molnar <mi...@redhat.com>
> > Cc: Borislav Petkov <b...@alien8.de>
> > Cc: Dave Hansen <dave.han...@linux.intel.com>
> > Cc: x...@kernel.org
> > Signed-off-by: Peter Xu <pet...@redhat.com>
> > ---
> > arch/x86/include/asm/pgtable.h | 1 -
> > include/asm-generic/pgtable-nopmd.h | 1 -
> > 2 files changed, 2 deletions(-)
>
> Reviewed-by: Jason Gunthorpe <j...@nvidia.com>
>
> > @@ -31,7 +31,6 @@ static inline int pud_none(pud_t pud) {
> > return 0; }
> > static inline int pud_bad(pud_t pud) { return 0; }
> > static inline int pud_present(pud_t pud) { return 1; }
> > static inline int pud_user(pud_t pud) { return 0; }
> > -static inline int pud_leaf(pud_t pud) { return 0; }
>
> It would be nice to have a final patch making the signatures
> consistent on all the arch inlines, it should return bool not int.
Makes sense, will do, thanks.
--
Peter Xu
