Re: [RFC PATCH v11 01/29] KVM: Wrap kvm_gfn_range.pte in a per-action union

[Paolo Bonzini]

On 7/19/23 01:44, Sean Christopherson wrote:
+       BUILD_BUG_ON(sizeof(gfn_range.arg) != sizeof(gfn_range.arg.raw));
+       BUILD_BUG_ON(sizeof(range->arg) != sizeof(range->arg.raw));

I think these should be static assertions near the definition of the 
structs.  However another possibility is to remove 'raw' and just assign 
the whole union.

Apart from this,

Reviewed-by: Paolo Bonzini <pbonz...@redhat.com>

Paolo

+       BUILD_BUG_ON(sizeof(gfn_range.arg) != sizeof(range->arg));