> On Wed, Feb 22, 2023 at 07:02:34AM +0000, Christophe Leroy wrote: > > > +/* Redefine rmb() to lwsync. */ > > > > WHat's the added value of this comment ? Isn't it obvious in the line > > below that rmb() is being defined to lwsync ? Please avoid useless comments. > Sure. Sorry, forgot to add that I wasn't adding this useless comment. Its just that checkpatch.pl complains that the memory barrier #define doesn't have a comment for it. > >
- [PATCH] arch/powerpc/include/asm/barrier.h: redefine rmb ... Kautuk Consul
- Re: [PATCH] arch/powerpc/include/asm/barrier.h: rede... Kautuk Consul
- Re: [PATCH] arch/powerpc/include/asm/barrier.h: rede... Christophe Leroy
- Re: [PATCH] arch/powerpc/include/asm/barrier.h: ... Kautuk Consul
- Re: [PATCH] arch/powerpc/include/asm/barrier... Kautuk Consul
- Re: [PATCH] arch/powerpc/include/asm/bar... Christophe Leroy
- Re: [PATCH] arch/powerpc/include/as... Kautuk Consul
- Re: [PATCH] arch/powerpc/include/asm/barrier... Christophe Leroy
- Re: [PATCH] arch/powerpc/include/asm/bar... Kautuk Consul
- [PATCH] arch/powerpc/include/asm/barrier.h: redefine... Kautuk Consul
- Re: [PATCH] arch/powerpc/include/asm/barrier.h: ... Kautuk Consul