rtualizat...@lists.linux-foundation.org>,
"james.bottom...@hansenpartnership.com"
<james.bottom...@hansenpartnership.com>, "jcmvb...@gmail.com"
<jcmvb...@gmail.com>, "thierry.red...@gmail.com" <thierry.red...@gmail.com>,
"ker...@xen0n.name" <ker...@xen0n.name>, "quic_neer...@quicinc.com"
<quic_neer...@quicinc.com>, linux-s390 <linux-s...@vger.kernel.org>,
"vschn...@redhat.com" <vschn...@redhat.com>, "john.ogn...@linutronix.de"
<john.ogn...@linutronix.de>, "ys...@users.sourceforge.jp"
<ys...@users.sourceforge.jp>, "feste...@gmail.com" <feste...@gmail.com>,
"del...@gmx.de" <del...@gmx.de>, "daniel.lezc...@linaro.org"
<daniel.lezc...@linaro.org>, "jonath...@nvidia.com" <jonath...@nvidia.com>,
"h...@linux.ibm.com" <h...@linux.ibm.com>, "l...@kernel.org" <l...@kernel.org>,
"linux-xte...@linux-xtensa.org" <linux-xte...@linux-xtensa.org>,
"jo...@kernel.org" <jo...@kernel.org>, "g...@linux.ibm.com"
<g...@linux.ibm.com>, "linux-arm-...@vger.kernel.org"
<linux-arm-...@vger.kernel.org>, "sudeep.hol
l...@arm.com" <sudeep.ho...@arm.com>, "linux-m...@lists.linux-m68k.org"
<linux-m...@lists.linux-m68k.org>, "sho...@gmail.com" <sho...@gmail.com>,
"linux-arm-ker...@lists.infradead.org" <linux-arm-ker...@lists.infradead.org>,
"ch...@zankel.net" <ch...@zankel.net>, "sb...@kernel.org" <sb...@kernel.org>,
"dingu...@kernel.org" <dingu...@kernel.org>, "bris...@redhat.com"
<bris...@redhat.com>, "chenhua...@kernel.org" <chenhua...@kernel.org>,
"alexander.shish...@linux.intel.com" <alexander.shish...@linux.intel.com>,
"mturque...@baylibre.com" <mturque...@baylibre.com>, "li...@rasmusvillemoes.dk"
<li...@rasmusvillemoes.dk>, "j...@joelfernandes.org" <j...@joelfernandes.org>,
Will Deacon <w...@kernel.org>, Boris Ostrovsky <boris.ostrov...@oracle.com>,
"khil...@kernel.org" <khil...@kernel.org>, "linux-c...@vger.kernel.org"
<linux-c...@vger.kernel.org>, "t...@atomide.com" <t...@atomide.com>,
"linux-snps-...@lists.infradead.org" <linux-snps-...@lists.infradead.org>, Mel
Gorman <mgor...@suse.de>, "j
acob.jun....@linux.intel.com" <jacob.jun....@linux.in
tel.com>, Arnd Bergmann <a...@arndb.de>, "ulli.kr...@googlemail.com"
<ulli.kr...@googlemail.com>, "vgu...@kernel.org" <vgu...@kernel.org>,
"j...@joshtriplett.org" <j...@joshtriplett.org>, Steven Rostedt
<rost...@goodmis.org>, "r...@vger.kernel.org" <r...@vger.kernel.org>, Mathieu
Desnoyers <mathieu.desnoy...@efficios.com>, "bc...@quicinc.com"
<bc...@quicinc.com>, "tsbog...@alpha.franken.de" <tsbog...@alpha.franken.de>,
"linux-par...@vger.kernel.org" <linux-par...@vger.kernel.org>,
"a...@brainfault.org" <a...@brainfault.org>, "sriva...@csail.mit.edu"
<sriva...@csail.mit.edu>, "linux-al...@vger.kernel.org"
<linux-al...@vger.kernel.org>, "shawn...@kernel.org" <shawn...@kernel.org>,
"da...@davemloft.net" <da...@davemloft.net>, "dal...@libc.org"
<dal...@libc.org>, Pv-drivers <pv-driv...@vmware.com>,
"bjorn.anders...@linaro.org" <bjorn.anders...@linaro.org>, "H. Peter Anvin"
<h...@zytor.com>, "sparcli...@vger.kernel.org" <sparcli...@vger.kernel.org>,
"linux-ri...@lists.infradead.org" <linux-r
i...@lists.infradead.org>, Anton Ivanov <anton.iva...@cambridgegreys.com>,
"jo...@southpole.se" <jo...@southpole.se>, "yury.no...@gmail.com"
<yury.no...@gmail.com>, "rich...@nod.at" <rich...@nod.at>, X86 ML
<x...@kernel.org>, "li...@armlinux.org.uk" <li...@armlinux.org.uk>,
"agr...@kernel.org" <agr...@kernel.org>, "a...@eecs.berkeley.edu"
<a...@eecs.berkeley.edu>, "paul...@kernel.org" <paul...@kernel.org>,
"frede...@kernel.org" <frede...@kernel.org>,
"stefan.kristians...@saunalahti.fi" <stefan.kristians...@saunalahti.fi>,
"openr...@lists.librecores.org" <openr...@lists.librecores.org>,
"paul.walms...@sifive.com" <paul.walms...@sifive.com>,
"linux-te...@vger.kernel.org" <linux-te...@vger.kernel.org>,
"namhy...@kernel.org" <namhy...@kernel.org>,
"andriy.shevche...@linux.intel.com" <andriy.shevche...@linux.intel.com>,
"jpoim...@kernel.org" <jpoim...@kernel.org>, Juergen Gross <jgr...@suse.com>,
"mon...@monstr.eu" <mon...@monstr.eu>, "linux-m...@vger.kernel.org"
<linux-m...@vger.kernel.org
>, "pal...@dabbelt.com" <pal...@dabbelt.com>, "linux-
hexa...@vger.kernel.org" <linux-hexa...@vger.kernel.org>, Borislav Petkov
<b...@alien8.de>, "johan...@sipsolutions.net" <johan...@sipsolutions.net>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>
Errors-To: linuxppc-dev-bounces+archive=mail-archive....@lists.ozlabs.org
Sender: "Linuxppc-dev"
<linuxppc-dev-bounces+archive=mail-archive....@lists.ozlabs.org>
On Mon, Jun 13, 2022 at 07:23:13PM +0000, Nadav Amit wrote:
> On Jun 13, 2022, at 11:48 AM, Srivatsa S. Bhat <sriva...@csail.mit.edu> wrote:
>
> > ⚠ External Email
> >
> > On 6/8/22 4:27 PM, Peter Zijlstra wrote:
> >> vmlinux.o: warning: objtool: acpi_idle_enter_s2idle+0xde: call to wbinvd()
> >> leaves .noinstr.text section
> >> vmlinux.o: warning: objtool: default_idle+0x4: call to arch_safe_halt()
> >> leaves .noinstr.text section
> >> vmlinux.o: warning: objtool: xen_safe_halt+0xa: call to
> >> HYPERVISOR_sched_op.constprop.0() leaves .noinstr.text section
> >>
> >> Signed-off-by: Peter Zijlstra (Intel) <pet...@infradead.org>
> >
> > Reviewed-by: Srivatsa S. Bhat (VMware) <sriva...@csail.mit.edu>
> >
> >>
> >> -static inline void wbinvd(void)
> >> +extern noinstr void pv_native_wbinvd(void);
> >> +
> >> +static __always_inline void wbinvd(void)
> >> {
> >> PVOP_ALT_VCALL0(cpu.wbinvd, "wbinvd", ALT_NOT(X86_FEATURE_XENPV));
> >> }
>
> I guess it is yet another instance of wrong accounting of GCC for
> the assembly blocks’ weight. I guess it is not a solution for older
> GCCs, but presumably ____PVOP_ALT_CALL() and friends should have
> used asm_inline or some new “asm_volatile_inline” variant.
Partially, some of the *SAN options also generate a metric ton of
nonsense when enabled and skew the compilers towards not inlining
things.
