o...@users.sourceforge.jp>, Linux-sh list <linux...@vger.kernel.org>, Fabio Estevam <feste...@gmail.com>, Helge Deller <del...@gmx.de>, Daniel Lezcano <daniel.lezc...@linaro.org>, Jonathan Hunter <jonath...@nvidia.com>, Mathieu Desnoyers <mathieu.desnoy...@efficios.com>, Frederic Weisbecker <frede...@kernel.org>, Len Brown <l...@kernel.org>, "open list:TENSILICA XTENSA PORT \(xtensa\)" <linux-xte...@linux-xtensa.org>, Sascha Hauer <ker...@pengutronix.de>, Vasily Gorbik <g...@linux.ibm.com>, linux-arm-msm <linux-arm-...@vger.kernel.org>, alpha <linux-al...@vger.kernel.org>, linux-m68k <linux-m...@lists.linux-m68k.org>, Stafford Horne <sho...@gmail.com>, Linux ARM <linux-arm-ker...@lists.infradead.org>, Chris Zankel <ch...@zankel.net>, Stephen Boyd <sb...@kernel.org>, Dinh Nguyen <dingu...@kernel.org>, Daniel Bristot de Oliveira <bris...@redhat.com>, Alexander Shishkin <alexander.shish...@linux.intel.com>, lpieral...@kernel.org, Rasmus Villemoes <li...@rasmusvillemoes.dk>, Joel Fernandes < j...@joelfernandes.org>, Will Deacon <w...@kernel.org>, Boris Ostrovsky <boris.ostrov...@oracle.com>, Kevin Hilman <khil...@kernel.org>, linux-c...@vger.kernel.org, Pv-drivers <pv-driv...@vmware.com>, "open list:SYNOPSYS ARC ARCHITECTURE" <linux-snps-...@lists.infradead.org>, Mel Gorman <mgor...@suse.de>, jacob.jun....@linux.intel.com, Yury Norov <yury.no...@gmail.com>, Hans Ulli Kroll <ulli.kr...@googlemail.com>, Vineet Gupta <vgu...@kernel.org>, linux-clk <linux-...@vger.kernel.org>, Josh Triplett <j...@joshtriplett.org>, Steven Rostedt <rost...@goodmis.org>, r...@vger.kernel.org, Borislav Petkov <b...@alien8.de>, bc...@quicinc.com, Thomas Bogendoerfer <tsbog...@alpha.franken.de>, Parisc List <linux-par...@vger.kernel.org>, Sudeep Holla <sudeep.ho...@arm.com>, Shawn Guo <shawn...@kernel.org>, David Miller <da...@davemloft.net>, Rich Felker <dal...@libc.org>, Tony Lindgren <t...@atomide.com>, amakha...@vmware.com, Bjorn Andersson <bjorn.anders...@linaro.org>, "H. Peter Anvin" <hpa@zyt or.com>, sparclinux <sparcli...@vger.kernel.org>, "op en list:QUALCOMM HEXAGON..." <linux-hexa...@vger.kernel.org>, linux-riscv <linux-ri...@lists.infradead.org>, Anton Ivanov <anton.iva...@cambridgegreys.com>, Jonas Bonn <jo...@southpole.se>, Richard Weinberger <rich...@nod.at>, the arch/x86 maintainers <x...@kernel.org>, Russell King - ARM Linux <li...@armlinux.org.uk>, Ingo Molnar <mi...@redhat.com>, Albert Ou <a...@eecs.berkeley.edu>, "Paul E. McKenney" <paul...@kernel.org>, Heiko Carstens <h...@linux.ibm.com>, Stefan Kristiansson <stefan.kristians...@saunalahti.fi>, Openrisc <openr...@lists.librecores.org>, Paul Walmsley <paul.walms...@sifive.com>, "open list:TEGRA ARCHITECTURE SUPPORT" <linux-te...@vger.kernel.org>, Namhyung Kim <namhy...@kernel.org>, Andy Shevchenko <andriy.shevche...@linux.intel.com>, jpoim...@kernel.org, Juergen Gross <jgr...@suse.com>, Michal Simek <mon...@monstr.eu>, "open list:BROADCOM NVRAM DRIVER" <linux-m...@vger.kernel.org>, Palmer Dabbelt <pal...@dabbelt.com>, Anup Patel <a...@brainfault.org>, Ivan Kokshay sky <i...@jurassic.park.msu.ru>, Johannes Berg <johan...@sipsolutions.net>, linuxppc-dev <linuxppc-dev@lists.ozlabs.org> Errors-To: linuxppc-dev-bounces+archive=mail-archive....@lists.ozlabs.org Sender: "Linuxppc-dev" <linuxppc-dev-bounces+archive=mail-archive....@lists.ozlabs.org>
On Wed, Jun 08, 2022 at 06:28:33PM +0200, Arnd Bergmann wrote: > On Wed, Jun 8, 2022 at 4:27 PM Peter Zijlstra <pet...@infradead.org> wrote: > > > > arch_cpu_idle() is a very simple idle interface and exposes only a > > single idle state and is expected to not require RCU and not do any > > tracing/instrumentation. > > > > As such, omap_sram_idle() is not a valid implementation. Replace it > > with the simple (shallow) omap3_do_wfi() call. Leaving the more > > complicated idle states for the cpuidle driver. > > > > Signed-off-by: Peter Zijlstra (Intel) <pet...@infradead.org> > > I see similar code in omap2: > > omap2_pm_idle() > -> omap2_enter_full_retention() > -> omap2_sram_suspend() > > Is that code path safe to use without RCU or does it need a similar change? It needs a similar change, clearly I was running on fumes to not have found that when grepping around the omap code :/
