On Mon, 30 Jun 2008, Paul Mackerras wrote:
> Eric B Munson writes:
>
> > --- a/include/asm-powerpc/elf.h
> > +++ b/include/asm-powerpc/elf.h
> > @@ -257,7 +257,8 @@ do {
> > \
> > else \
> > clear_thread_flag(TIF_ABI_PENDING); \
> > if (personality(current->personality) != PER_LINUX32) \
> > - set_personality(PER_LINUX); \
> > + set_personality(PER_LINUX | \
> > + (current->personality & PER_INHERIT)); \
>
> Couldn't we use ~PER_MASK here instead of PER_INHERIT? That would
> mean we wouldn't have to modify include/linux/personality.h, and we
> wouldn't have to keep updating PER_INHERIT as more flags get added.
>
> (Nice patch description, BTW. Thanks.)
>
> Paul.
> Yeah, ~PER_MASK will work fine. I used PER_INHERIT first because I was not sure if there were values that should not be carried forward. I will have an updated patch out shortly. Eric
signature.asc
Description: Digital signature
_______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
