Eric B Munson writes:

> --- a/include/asm-powerpc/elf.h
> +++ b/include/asm-powerpc/elf.h
> @@ -257,7 +257,8 @@ do {                                                      
>         \
>       else                                                    \
>               clear_thread_flag(TIF_ABI_PENDING);             \
>       if (personality(current->personality) != PER_LINUX32)   \
> -             set_personality(PER_LINUX);                     \
> +             set_personality(PER_LINUX |                     \
> +                     (current->personality & PER_INHERIT));  \

Couldn't we use ~PER_MASK here instead of PER_INHERIT?  That would
mean we wouldn't have to modify include/linux/personality.h, and we
wouldn't have to keep updating PER_INHERIT as more flags get added.

(Nice patch description, BTW.  Thanks.)

Paul.
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev

Reply via email to