Hi Hari, Thank you for the patch! Yet something to improve:
[auto build test ERROR on powerpc/next] [also build test ERROR on v5.16-rc2 next-20211126] [cannot apply to mpe/next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Hari-Bathini/powerpc-handle-kdump-appropriately-with-crash_kexec_post_notifiers-option/20211126-021120 base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next config: powerpc-iss476-smp_defconfig (https://download.01.org/0day-ci/archive/20211127/202111270740.t4qbma4l-...@intel.com/config) compiler: powerpc-linux-gcc (GCC) 11.2.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/112b5fcac650e78c2130b7f43ef66d965e69623e git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Hari-Bathini/powerpc-handle-kdump-appropriately-with-crash_kexec_post_notifiers-option/20211126-021120 git checkout 112b5fcac650e78c2130b7f43ef66d965e69623e # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=powerpc SHELL=/bin/bash If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <l...@intel.com> All errors (new ones prefixed by >>): arch/powerpc/kernel/smp.c: In function 'crash_smp_send_stop': >> arch/powerpc/kernel/smp.c:645:27: error: passing argument 1 of >> 'smp_call_function' from incompatible pointer type >> [-Werror=incompatible-pointer-types] 645 | smp_call_function(crash_stop_this_cpu, NULL, 0); | ^~~~~~~~~~~~~~~~~~~ | | | void (*)(struct pt_regs *) In file included from include/linux/lockdep.h:14, from include/linux/rcupdate.h:29, from include/linux/rculist.h:11, from include/linux/pid.h:5, from include/linux/sched.h:14, from include/linux/sched/mm.h:7, from arch/powerpc/kernel/smp.c:18: include/linux/smp.h:149:40: note: expected 'smp_call_func_t' {aka 'void (*)(void *)'} but argument is of type 'void (*)(struct pt_regs *)' 149 | void smp_call_function(smp_call_func_t func, void *info, int wait); | ~~~~~~~~~~~~~~~~^~~~ cc1: all warnings being treated as errors Kconfig warnings: (for reference only) WARNING: unmet direct dependencies detected for HOTPLUG_CPU Depends on SMP && (PPC_PSERIES || PPC_PMAC || PPC_POWERNV || FSL_SOC_BOOKE Selected by - PM_SLEEP_SMP && SMP && (ARCH_SUSPEND_POSSIBLE || ARCH_HIBERNATION_POSSIBLE && PM_SLEEP vim +/smp_call_function +645 arch/powerpc/kernel/smp.c 632 633 void crash_smp_send_stop(void) 634 { 635 static bool stopped = false; 636 637 if (stopped) 638 return; 639 640 stopped = true; 641 642 #ifdef CONFIG_NMI_IPI 643 smp_send_nmi_ipi(NMI_IPI_ALL_OTHERS, crash_stop_this_cpu, 1000000); 644 #else > 645 smp_call_function(crash_stop_this_cpu, NULL, 0); 646 #endif /* CONFIG_NMI_IPI */ 647 } 648 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
