On Sat, Jun 14, 2008 at 9:57 AM, Pierre Ossman <[EMAIL PROTECTED]> wrote: > On Thu, 5 Jun 2008 20:16:24 +0400 > Anton Vorontsov <[EMAIL PROTECTED]> wrote: > >> Here is v3. I'm out of ideas if you won't like it. :-) >> >> v3: >> - Now these bindings are using bus notifiers chain, thus we adhere to the >> spi bus. >> > > Now this was nice and clean. I take it Grant doesn't like this version > though. What's the downside of it?
No, I don't. I like the v2 approach better as long as it is been changed to address your comments. This approach I think is needlessly complex and non-obvious (relying on the notification chain instead of being part of the probe call). It will break in non-obvious ways if the notifier module is loaded after the mmc_spi driver. Cheers, g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
