On Mon, Jul 26, 2021 at 05:42:43PM +0200, Michal Suchanek wrote: > commit 7c6986ade69e ("powerpc/stacktrace: Fix spurious "stale" traces in > raise_backtrace_ipi()") > introduces udelay() call without including the linux/delay.h header. > This may happen to work on master but the header that declares the > functionshould be included nonetheless. > > Fixes: 7c6986ade69e ("powerpc/stacktrace: Fix spurious "stale" traces in > raise_backtrace_ipi()") > Signed-off-by: Michal Suchanek <msucha...@suse.de> > --- > arch/powerpc/kernel/stacktrace.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/powerpc/kernel/stacktrace.c > b/arch/powerpc/kernel/stacktrace.c > index 2b0d04a1b7d2..a17ac10f86b1 100644 > --- a/arch/powerpc/kernel/stacktrace.c > +++ b/arch/powerpc/kernel/stacktrace.c > @@ -12,6 +12,7 @@ > #include <linux/kallsyms.h> > #include <linux/module.h> > #include <linux/nmi.h> > +#include <linux/delay.h> > #include <linux/sched.h> > #include <linux/sched/debug.h> > #include <linux/sched/task_stack.h>
Hmm, I believe we try to keep the list of includes sorted in alphabetical order. Gabriel